Skip to content

Allow use of search parameter for merge requests #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Allow use of search parameter for merge requests #253

merged 1 commit into from
Jan 15, 2018

Conversation

velichkin
Copy link
Contributor

It's possible to use search parameter for merge-requests. The only change is to add to $resolver.

It's possible to use search parameter for merge-requests. The only change is to add to $resolver.
@velichkin
Copy link
Contributor Author

ping @m4tthumphrey

@fbourigault
Copy link
Contributor

search seems to be undocumented for merge requests. I don't like so much adding undocumented Gitlab API stuff as it may be considered as internal.

Do you have some references about the existence of this search parameter?

@velichkin
Copy link
Contributor Author

I've checked it and it works. But, unfortunately, I haven't found it in official API.

@fbourigault
Copy link
Contributor

@m4tthumphrey @m1guelpf what is your point of view about undocumented Gitlab API features support in this library?

@velichkin
Copy link
Contributor Author

Here is the discussion about this parameter - https://gitlab.com/gitlab-org/gitlab-ce/issues/38318

@velichkin
Copy link
Contributor Author

velichkin commented Jan 11, 2018

https://gitlab.com/gitlab-org/gitlab-ce/issues/38318
Documentation will be updated with 10.4 release

@fbourigault
Copy link
Contributor

Thank you!

@fbourigault fbourigault merged commit 461776a into GitLabPHP:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants